Skip to content

destroy temporarily used fdb #5089

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

aakash10292
Copy link
Contributor

Distributed create uses an fdb object to create push connectors. Destroy it when it's no longer needed.

@aakash10292 aakash10292 requested a review from dorinhogea March 28, 2025 13:19
@aakash10292 aakash10292 force-pushed the aar_credrop_fdb_destroy branch from a82c7a5 to 49e0d88 Compare March 28, 2025 13:19
Copy link

@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coding style check: Success ✓.
Smoke testing: Success ✓.
Cbuild submission: Success ✓.
Regression testing: 7/604 tests failed ⚠.

The first 10 failing tests are:
osql_cleanup
timepart_readonly
phys_rep_tiered
phys_rep_tiered_nosource_generated
phys_rep_tiered_firstfile_generated
incoherent_sql
dbcreate

@aakash10292
Copy link
Contributor Author

cdb2test Mar 28 09:58:16 2025 success aar_credrop_fdb_destroy.R20250328.0

@aakash10292 aakash10292 force-pushed the aar_credrop_fdb_destroy branch from 49e0d88 to 02be93d Compare March 28, 2025 16:42
Copy link
Contributor

@dorinhogea dorinhogea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link

@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coding style check: Error. ⚠.
Smoke testing: Success ✓.
Cbuild submission: Success ✓.
Regression testing: 7/604 tests failed ⚠.

The first 10 failing tests are:
sc_truncate
timepart_readonly
phys_rep_tiered
phys_rep_tiered_nosource_generated
phys_rep_tiered_firstfile_generated
cldeadlock
dbcreate

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants